Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 14, 2019

r? @RalfJung

fixes the ice in #53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
@RalfJung
Copy link
Member

(I'm on a conference, and will start catching up with my emails on Jan 22nd.)

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 15, 2019

@bors try

@bors
Copy link
Collaborator

bors commented Jan 15, 2019

⌛ Trying commit b805232 with merge a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8...

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 15, 2019

@rust-timer build a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8

@rust-timer
Copy link
Collaborator

Success: Queued a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8 with parent 33e6df4, comparison URL.

@kennytm

This comment has been minimized.

@bors

This comment has been minimized.

bors added a commit that referenced this pull request Jan 15, 2019
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in #53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor
@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2019
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2019
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit a5a18a4e3822d2c19cb9cc6752bcc8930f8162e8

@bors
Copy link
Collaborator

bors commented Jan 22, 2019

☔ The latest upstream changes (presumably #57830) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 23, 2019

📌 Commit d4ee556 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Jan 23, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2019
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 24, 2019
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in rust-lang#53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor
Centril added a commit to Centril/rust that referenced this pull request Jan 24, 2019
Get rid of the fake stack frame for reading from constants

r? @RalfJung

fixes the ice in rust-lang#53708 but still keeps around the wrong "non-exhaustive match" error

cc @varkor
bors added a commit that referenced this pull request Jan 24, 2019
Rollup of 9 pull requests

Successful merges:

 - #57380 (Fix Instant/Duration math precision & associativity on Windows)
 - #57606 (Get rid of the fake stack frame for reading from constants)
 - #57803 (Several changes to libunwind for SGX target)
 - #57846 (rustdoc: fix ICE from loading proc-macro stubs)
 - #57860 (Add os::fortanix_sgx::ffi module)
 - #57861 (Don't export table by default in wasm)
 - #57863 (Add suggestion for incorrect field syntax.)
 - #57867 (Fix std::future::from_generator documentation)
 - #57873 (Stabilize no_panic_pow)

Failed merges:

r? @ghost
@bors bors merged commit d4ee556 into rust-lang:master Jan 25, 2019
@oli-obk oli-obk deleted the shrink branch June 15, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants